Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: consistent result in dropping NA from CSV #29424

Merged
merged 1 commit into from
Nov 6, 2019
Merged

TST: consistent result in dropping NA from CSV #29424

merged 1 commit into from
Nov 6, 2019

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Nov 5, 2019

Closes #21131

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate IO CSV read_csv, to_csv labels Nov 5, 2019
@gfyoung gfyoung added this to the 1.0 milestone Nov 5, 2019
@gfyoung gfyoung force-pushed the test-io-csv-parser-drop-na branch from 850bd6b to 68e870c Compare November 5, 2019 23:54
@gfyoung
Copy link
Member Author

gfyoung commented Nov 6, 2019 •
edited
Loading

@pandas-dev/pandas-core :

https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=20243

Any ideas as to why this would be failing consistently? master (d569905) is okay, and this branch is based off master, and I don't think this commit is the cause for the issue.

Being tracked and handled in #29432

@gfyoung gfyoung force-pushed the test-io-csv-parser-drop-na branch from 68e870c to 54bd6ae Compare November 6, 2019 19:38
@jreback jreback merged commit cacc9e2 into pandas-dev:master Nov 6, 2019
@jreback
Copy link
Contributor

jreback commented Nov 6, 2019

thanks @gfyoung

@gfyoung gfyoung deleted the test-io-csv-parser-drop-na branch November 6, 2019 21:43
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
@gfyoung
TST: consistent result in dropping NA from CSV (pandas-dev#29424)
30800ee 
Closes pandas-dev#21131
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@gfyoung @proost
TST: consistent result in dropping NA from CSV (pandas-dev#29424)
40fa182 
Closes pandas-dev#21131
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@gfyoung @proost
TST: consistent result in dropping NA from CSV (pandas-dev#29424)
e7074e9 
Closes pandas-dev#21131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO CSV read_csv, to_csv Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Change from of 'c' to 'python' engine in read_csv gives unexpected side-effect
2 participants
@gfyoung @jreback